Implement visitor for polymorphic magnetic field #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
force-pushed
the
refactor/bfield_visitor
branch
from
3be3bd3 to
b78a058
Compare
This commit implements the visitor logic that I proposed for acts-project#1033, drastically reducing the amount of boilerplate we need to handle different magnetic field types and increasing the maintainability of the code significantly. This also paves the way for polymorphic detector types which we will need in the future.
stephenswat
force-pushed
the
refactor/bfield_visitor
branch
from
b78a058 to
21ce521
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the visitor logic that I proposed for #1033, drastically reducing the amount of boilerplate we need to handle different magnetic field types and increasing the maintainability of the code significantly. This also paves the way for polymorphic detector types which we will need in the future.