Skip to content

Honour subspaces in measurement creation #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

Honour subspaces in measurement creation #1066

merged 2 commits into from
Jul 14, 2025

Conversation

stephenswat
Copy link
Member

This commit enhances the measurement creation to copy subspace information from the detector description.

@stephenswat stephenswat added the feature New feature or request label Jul 9, 2025
@stephenswat stephenswat force-pushed the feat/measurement_subspaces branch from 01b9a39 to 82f0f24 Compare July 9, 2025 13:25
krasznaa
krasznaa reviewed Jul 9, 2025
View reviewed changes
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this is a draft, and let's see first if this is where we're going with this, but just to have it written down:

We will also need to make an update around here:

https://github.com/acts-project/traccc/blob/main/core/include/traccc/clusterization/impl/measurement_creation.ipp#L148

stephenswat and others added 2 commits July 14, 2025 10:16
@stephenswat @krasznaa
Honour subspaces in measurement creation
38eb689 
This commit enhances the measurement creation to copy subspace
information from the detector description.
@krasznaa
Made the host clusterization set the measurement subspace correctly.
2545938 
While tweaking the EDM and device code a little.
@krasznaa krasznaa force-pushed the feat/measurement_subspaces branch from 82f0f24 to 2545938 Compare July 14, 2025 08:50
@krasznaa krasznaa marked this pull request as ready for review July 14, 2025 08:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

krasznaa
krasznaa approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the CI succeeds, let's push this through for the benefit of the G-200 pipeline.

@krasznaa krasznaa enabled auto-merge (squash) July 14, 2025 09:48
@krasznaa krasznaa merged commit a804d60 into acts-project:main Jul 14, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasznaa krasznaa krasznaa approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenswat @krasznaa