De-Template (Host) Track Fitting, main branch (2024.10.28.)#756
Merged
stephenswat merged 4 commits intoacts-project:mainfrom Nov 13, 2024
Merged
Conversation
krasznaa
added
build
krasznaa
force-pushed
the
DeTemplateTrackFitting-main-20241024
branch
2 times, most recently
from
502fec6 to
145d6e1
Compare
beomki-yeo
reviewed
Oct 29, 2024
Contributor
beomki-yeo
left a comment
beomki-yeo
left a comment
There was a problem hiding this comment.
There are some naming issues that concern me..
krasznaa
force-pushed
the
DeTemplateTrackFitting-main-20241024
branch
3 times, most recently
from
47a7e27 to
6571488
Compare
krasznaa
force-pushed
the
DeTemplateTrackFitting-main-20241024
branch
from
6571488 to
9b4ecee
Compare
Member
Author
|
Please have a look @paulgessinger. I now still have a specific algorithm interface for performing the fitting "in specific ways", but also expose the template code that would allow clients to do different things as well if they so wished. I think this design could be extended to the device code as well. 🤔 |
krasznaa
commented
Nov 4, 2024
krasznaa
force-pushed
the
DeTemplateTrackFitting-main-20241024
branch
from
0b6e301 to
78dce01
Compare
krasznaa
force-pushed
the
DeTemplateTrackFitting-main-20241024
branch
3 times, most recently
from
6e3a8a9 to
da27835
Compare
stephenswat
approved these changes
Nov 12, 2024
It is a replacement for traccc::fitting_algorithm, without a templated API.
Updating all users to use traccc::host::kf_algorithm instread.
This way clients can have access to the full details of the code if they want to, while also getting algorithms that would perform fitting in one very specific way.
krasznaa
force-pushed
the
DeTemplateTrackFitting-main-20241024
branch
from
da27835 to
b4c53e0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the next step in my crusade to make the reconstruction algorithms use non-templated interfaces. 😄
In this I renamed
traccc::fitting_algorithmtotraccc::host::kf_algorithm, along exactly the same lines as what I did fortraccc::host::ckf_algorithmin #722.As before, one important aspect of this is to get the memory needs of the build under control. In the current
mainbranch we use the following amounts of memory for compiling a few representative source files:seq_example.cpp: 1.4 GBcpu/throughput_st.cpp: 700 MBThis PR introduces 3 new source files, and reduces the memory needs of the previous examples like:
kf_algorithm.cpp: 320 MBkf_algorithm_teldet_cfield.cpp: 475 MBkf_algorithm_defdet_cfield.cpp: 650 MBseq_example.cpp: 1.0 GBcpu/throughput_st.cpp: 575 MBClearly this is not the end of the road yet, but I'm fairly happy with what the PR does for the build's memory usage.