Add CLI options to control logging verbosity #897
Conversation
This commit adds the `-v` and `-q` flag that control verbosity, respectively making the code more verbose or more quiet. Also adds these options to the throughput examples.
stephenswat
added
feature
|
| if (lvl == traccc::Logging::Level::VERBOSE) { | ||
| verbosity_string = "Verbose"; | ||
| } else if (lvl == traccc::Logging::Level::DEBUG) { | ||
| verbosity_string = "Debug"; | ||
| } else if (lvl == traccc::Logging::Level::INFO) { | ||
| verbosity_string = "Info"; | ||
| } else if (lvl == traccc::Logging::Level::WARNING) { | ||
| verbosity_string = "Warning"; | ||
| } else if (lvl == traccc::Logging::Level::ERROR) { | ||
| verbosity_string = "Error"; | ||
| } else if (lvl == traccc::Logging::Level::FATAL) { | ||
| verbosity_string = "Fatal"; | ||
| } |
There was a problem hiding this comment.
- This would seem like a perfect place for
switch--case; - Why change the capitalization on the printout wrt. the enum names? I would prefer to keep the same capitalized names for the printout at well.
There was a problem hiding this comment.
Hmm, I personally prefer to avoid switch statements whenever convenient because they more confusing and error prone than if-else statements, but I don't feel tremendously strongly about it.
Neither do I feel strongly about the capitalization! We can keep it all-caps in line with the enum values.
There was a problem hiding this comment.
Also, we could just use the following heere:
https://github.com/acts-project/acts/blob/main/Core/include/Acts/Utilities/Logger.hpp#L168
There was a problem hiding this comment.
Oh that's a really nice idea!
|
What about this one? Anything preventing us from finishing this one? |
This commit adds the
-vand-qflag that control verbosity, respectively making the code more verbose or more quiet. Also adds these options to the throughput examples.