Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker.md, dockerfile and docker-compose.yaml #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Adesoji1
Copy link

@Mohit21GoJs kindly test

@Mohit21GoJs Mohit21GoJs self-requested a review January 17, 2025 08:25
@Mohit21GoJs
Copy link
Collaborator

@Adesoji1 Thanks for the efforts, let me review it and update here 👍

Docker.md Show resolved Hide resolved
@Adesoji1
Copy link
Author

Adesoji1 commented Jan 19, 2025 via email

@Mohit21GoJs
Copy link
Collaborator

@Adesoji1 The point i wanted to make is not to use node 18 or 22.

I am using:

Docker version 27.3.1, build ce12230
Docker Compose version v2.29.7

And for me command docker build --no-cache -t my-nextjs-app .

Do not work, i believe we can replace node-22-alpine to node-22 in line 2, as we have multi stage docker build, so we can keep node-22-alpine in line 26.

The point i am trying to highlight is we use docker to make sure it just does not work only in your machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants