Skip to content

Commit

Permalink
Fix qlever stop taking a long time (#29)
Browse files Browse the repository at this point in the history
The problem was that in the previous setup SIGNALS were not forwarded. Every `qlever stop` thus waited until docker forcefully terminated the container after 10s. `--init` starts an init process in the container that forwards SIGNALS. The containers now stop instantly.

Some technical background: https://hynek.me/articles/docker-signals/
  • Loading branch information
Qup42 authored Feb 24, 2024
1 parent 5d565c5 commit 4896870
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/qlever/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,7 @@ def action_start(self, only_show=False):
f" -w /index"
f" --entrypoint bash"
f" --name {docker_config['container_server']}"
f" --init"
f" {docker_config['image']}"
f" -c {shlex.quote(cmdline)}")
else:
Expand Down

0 comments on commit 4896870

Please sign in to comment.