Delete old and by now unused code for answering full-text queries #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
+ Coverage 85.80% 87.29% +1.48%
==========================================
Files 308 304 -4
Lines 29261 27470 -1791
Branches 3430 3096 -334
==========================================
- Hits 25108 23980 -1128
+ Misses 2787 2367 -420
+ Partials 1366 1123 -243 ☔ View full report in Codecov by Sentry. |
hannahbast
changed the title
hannahbast
approved these changes
Jan 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1093 we use a much simpler approach for answering full-text queries that contain
ql:contains-wordandql:contains-entity. That PR made a lot of old code for the text index obsolete. This code is now deleted.