Fix bug in WKT point literal regex #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused WKT literals with more than one digit, but without a decimal point in the latitude coordinate to be falsely rejected as GeoPoints. Fixes ad-freiburg#1579
Conformance check passed ✅No test result changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1593 +/- ##
==========================================
+ Coverage 89.00% 89.08% +0.08%
==========================================
Files 368 371 +3
Lines 33888 34437 +549
Branches 3828 3899 +71
==========================================
+ Hits 30161 30678 +517
- Misses 2473 2484 +11
- Partials 1254 1275 +21 ☔ View full report in Codecov by Sentry. |
|
hannahbast
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the regular expression that is used for extracting points from WKT literals. The bug caused WKT literals with more than one digit but without a decimal point in the latitude coordinate to be falsely rejected as GeoPoints. Fixes #1579