Add a numPathsPerTarget parameter to PathSearch #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the PathSearch query used a lot of memory for certain datasets and queries. In that case, the result can not be build and it is not possible to determine where the problem lies. This change adds the parameter numPathsPerTarget. The PathSearch will only search and store paths if the number of paths is lower/equal to the parameter value.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1596 +/- ##
==========================================
+ Coverage 89.08% 89.11% +0.03%
==========================================
Files 371 371
Lines 34437 34456 +19
Branches 3899 3903 +4
==========================================
+ Hits 30678 30706 +28
+ Misses 2484 2480 -4
+ Partials 1275 1270 -5 ☔ View full report in Codecov by Sentry. |
Conformance check passed ✅No test result changes. |
|
ullingerc
pushed a commit
to ullingerc/qlever
that referenced
this pull request
Nov 12, 2024
When this parameter is set, the `PathSearch` service limits the number of paths per `[source, target]` pair. This makes it possible to use the path search for cases where enumerating all paths would exhaust the available time and memory constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this parameter is set, the
PathSearchservice limits the number of paths per[source, target]pair. This makes it possible to use the path search for cases where enumerating all paths would exhaust the available time and memory constraints.