Refactor VocabularyMerger to use EqualWords for duplicate handling #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the VocabularyMerger implementation to properly handle duplicate word occurrences during vocabulary merging: - Introduced EqualWords struct to collect multiple occurrences of the same iriOrLiteral across partial vocabularies - Changed from lastTripleComponent_ to currentWord_ tracking - Updated WordCallback concept (removed inTextIndex parameter) - Modified EqualWords constructor to remove inTextIndex parameter - Improved duplicate handling logic to merge isExternal flags - Updated writePartialVocabularyToFile to remove inTextIndex serialization - Fixed TripleComponentWithIndex constructor calls The key improvement is that when the same word appears multiple times with different isExternal values, they are properly merged with the OR logic applied to isExternal. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Overview
Conformance check passed ✅No test result changes. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2433 +/- ##
=======================================
Coverage 91.44% 91.45%
=======================================
Files 462 462
Lines 46907 46933 +26
Branches 5240 5241 +1
=======================================
+ Hits 42896 42923 +27
- Misses 2511 2513 +2
+ Partials 1500 1497 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the VocabularyMerger implementation to properly handle duplicate word occurrences during vocabulary merging:
The key improvement is that when the same word appears multiple times with different isExternal values, they are properly merged with the OR logic applied to isExternal.
🤖 Generated with Claude Code