Add bit pattern encoding support to EncodedIriManager #2451
+371
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend EncodedIriManager to support a new bit pattern encoding mode alongside the existing plain digit encoding. This allows efficient encoding of IRIs with numeric values where certain bits are always zero. Key changes: - Add PrefixConfig struct to store prefix with optional bit range - Implement encodeBitPattern/decodeBitPattern for compressed encoding - Update JSON serialization with backward-compatible format - Add comprehensive unit tests for new functionality The new mode compresses values by removing bits in a specified range that must be zero, allowing more efficient storage while maintaining decodability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Update bit pattern encoding to use C++ conventions with half-open intervals [bitStart, bitEnd) instead of inclusive ranges. Changes: - Update PrefixConfig constructor to use exclusive upper bound - Adjust encodeBitPattern loop condition (< instead of <=) - Fix decodeBitPattern shift calculation - Update all documentation to reflect half-open intervals - Update all unit tests with corrected bit ranges 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Enable users to specify bit pattern encoding via IndexBuilderConfig
and propagate it through to the EncodedIriManager.
Changes:
- Add prefixesForIdEncodedIrisWithBitPattern_ to IndexBuilderConfig
- Add setPrefixesForEncodedValuesWithBitPattern() to IndexImpl
- Update Qlever.cpp to call new configuration method
- Update IndexTestHelpers to handle both plain and bit pattern modes
- Maintain backward compatibility with existing plain prefix configs
Usage example in Qlever.h:
config.prefixesForIdEncodedIris_ = {"http://example.org/"};
config.prefixesForIdEncodedIrisWithBitPattern_ = {
{"http://bitpattern.org/", 10, 16} // bits [10, 16) must be zero
};
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Overview
Conformance check passed ✅No test result changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend EncodedIriManager to support a new bit pattern encoding mode alongside the existing plain digit encoding. This allows efficient encoding of IRIs with numeric values where certain bits are always zero.
Key changes:
The new mode compresses values by removing bits in a specified range that must be zero, allowing more efficient storage while maintaining decodability.
🤖 Generated with Claude Code