Track parsing in timing #2463
Open
Track parsing in timing #2463
+55
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbast
requested changes
Oct 23, 2025
Member
hannahbast
left a comment
hannahbast
left a comment
There was a problem hiding this comment.
@Qup42 Quick feedback from 1-1 with Julian:
- Parsing time not reset to 0 for chained updates
- Time unaccounted for is now more than 0% again
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2463 +/- ##
==========================================
- Coverage 91.47% 91.09% -0.38%
==========================================
Files 463 465 +2
Lines 46955 39699 -7256
Branches 5242 5312 +70
==========================================
- Hits 42952 36165 -6787
+ Misses 2506 2024 -482
- Partials 1497 1510 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobinTF
requested changes
Nov 6, 2025
Collaborator
RobinTF
left a comment
RobinTF
left a comment
There was a problem hiding this comment.
Just some minor suggestions
Overview
Conformance check passed ✅No test result changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time to parse an operation is now also tracked in the timing. Also fixed a bug in
resetofTimeTracer. The TimeTracer now is ashared_ptron the outer levels because we would have lifetime issues withTimeTracer&otherwise. (I assume that the process was similar for theCancellationHandle.)