Backport src/parser/ to C++17 #2470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes C++17 compatibility fixes for the parser module: - Remove noexcept from copy constructors (not allowed in C++17) - Add static_assert checks for copyable types - Replace emplace_back with push_back where needed for C++17 compatibility - Use std::mem_fn for member function pointers in std::visit - Add necessary backport headers (concepts.h, three_way_comparison.h) - Update CMakeLists.txt to add onlySpatialQuery library - Fix structured binding usage with std::get vs get 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
joka921
commented
Oct 28, 2025
src/parser/GraphPatternOperation.h
Outdated
Comment on lines
215
to
230
| static_assert(ql::concepts::copyable<Optional>); | ||
| static_assert(ql::concepts::copyable<Union>); | ||
| static_assert(ql::concepts::copyable<Subquery>); | ||
| static_assert(ql::concepts::copyable<TransPath>); | ||
| static_assert(ql::concepts::copyable<Bind>); | ||
| static_assert(ql::concepts::copyable<BasicGraphPattern>); | ||
| static_assert(ql::concepts::copyable<Values>); | ||
| static_assert(ql::concepts::copyable<Service>); | ||
| static_assert(ql::concepts::copyable<PathQuery>); | ||
| static_assert(ql::concepts::copyable<SpatialQuery>); | ||
| static_assert(ql::concepts::copyable<TextSearchQuery>); | ||
| static_assert(ql::concepts::copyable<Minus>); | ||
| static_assert(ql::concepts::copyable<GroupGraphPattern>); | ||
| static_assert(ql::concepts::copyable<Describe>); | ||
| static_assert(ql::concepts::copyable<Load>); | ||
| static_assert(ql::concepts::copyable<NamedCachedResult>); |
Member
Author
There was a problem hiding this comment.
Those can also go (can easily be reinstated for further stuff).
| MagicServiceQuery() = default; | ||
| MagicServiceQuery(MagicServiceQuery&& other) noexcept = default; | ||
| MagicServiceQuery(const MagicServiceQuery& other) noexcept = default; | ||
| MagicServiceQuery(const MagicServiceQuery& other) = default; |
Member
Author
There was a problem hiding this comment.
this might in fact throw (it is the copy, not the move operation after all), so the older compiler was right to complain about this.
Signed-off-by: Johannes Kalmbach <[email protected]>
ullingerc
approved these changes
Oct 28, 2025
| TripleVec additionalTriples) { | ||
| for (auto&& [predicate, object] : std::move(predicateObjectPairs)) { | ||
| triples.emplace_back(subject, std::move(predicate), std::move(object)); | ||
| triples.push_back({subject, std::move(predicate), std::move(object)}); |
Member
There was a problem hiding this comment.
Is emplace back really unsupported in c++17? this surprised me
Member
Author
There was a problem hiding this comment.
It is not emplace_back per se, but in combination with aggregates (structs without an explicit constructor):
std::array<int, 3>(4, 5, 6) (with round parentheses) works only in C++20, and the emplace_back is a consequence of this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2470 +/- ##
==========================================
- Coverage 91.07% 91.07% -0.01%
==========================================
Files 466 466
Lines 39706 39709 +3
Branches 5309 5312 +3
==========================================
Hits 36164 36164
Misses 2034 2034
- Partials 1508 1511 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Johannes Kalmbach <[email protected]>
Overview
Conformance check passed ✅No test result changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes C++17 compatibility fixes for the parser module:
🤖 Generated with Claude Code