Backport src/index/ to C++17 #2478
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes C++17 compatibility fixes for the index module: - Replace inline constexpr variable initialization with function-based initialization for global atomics - Use QL_CONSTEXPR macro for static constexpr variables - Add QLEVER_CPP_17 preprocessor guards for expensive checks that use ranges - Replace inline constexpr with static constexpr where appropriate - Use constexpr lambda variables instead of C++20 consteval functions - Update three_way_comparison and equality operator macros for C++17 - Replace std::accumulate with std::reduce where parallel execution is beneficial - Add backport headers for StartsWith/EndsWith and algorithm utilities - Fix conversion issues with int64_t vs int for Bool datatype 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
joka921
commented
Oct 29, 2025
Member
Author
joka921
left a comment
joka921
left a comment
There was a problem hiding this comment.
A first round of self-reviews.
Comment on lines
+34
to
+44
| inline std::atomic<size_t>& BUFFER_SIZE_JOIN_PATTERNS_WITH_OSP() { | ||
| static std::atomic<size_t> value = 50'000; | ||
| return value; | ||
| } | ||
|
|
||
| // When merging the vocabulary, this many finished words are buffered | ||
| // before they are written to the output. | ||
| constinit inline std::atomic<size_t> BATCH_SIZE_VOCABULARY_MERGE = 10'000'000; | ||
| inline std::atomic<size_t>& BATCH_SIZE_VOCABULARY_MERGE() { | ||
| static std::atomic<size_t> value = 10'000'000; | ||
| return value; | ||
| } |
Member
Author
There was a problem hiding this comment.
As those are not depending on anything, I can probably just use inline variables. (also below).
| tracer.beginTrace("rewriteLocalVocabEntries"); | ||
| rewriteLocalVocabEntriesAndBlankNodes(triples); | ||
| tracer.endTrace("rewriteLocalVocabEntries"); | ||
| #ifndef QLEVER_CPP_17 |
Member
Author
There was a problem hiding this comment.
TODO Check if this commenting out is still needed...
| // directly because of cyclic dependencies. | ||
| static constexpr std::string_view proxyTag = "LveIdProxy"; | ||
| using IdProxy = ad_utility::TypedIndex<uint64_t, proxyTag>; | ||
| static inline constexpr ad_utility::IndexTag lveIdProxyTag = "LveIdProxy"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes C++17 compatibility fixes for the index module:
🤖 Generated with Claude Code