Skip to content

Conversation

@RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Nov 4, 2025

This PR fixes #2483. Queries of the form

PREFIX textSearch: <https://qlever.cs.uni-freiburg.de/textSearch/>

SELECT ?p (count(distinct ?s) as ?cnt) WHERE {
    ?s ?p ?e
    SERVICE textSearch: {      
      ?t textSearch:contains [ textSearch:word "olympic" ] .
      ?t textSearch:contains [ textSearch:entity ?e ] .
	}
}  GROUP BY ?p

should work now. This also applies to other "magic service queries", but at least for spatial joins the pattern trick seems to mess with the query plan leading to different errors.

// For `MagicServiceQuery`s delegate to the nested graph patterns.
if (arg.childGraphPattern_.has_value()) {
return check(arg.childGraphPattern_.value());
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we'd actually want this or if it would be better to always return false because the special service queries are special for a reason.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

@sparql-conformance
Copy link

Overview

Number of Tests Passed ✅ Failed ❌ Intended ⚠️ Not tested
525 439 19 67 0

Conformance check passed ✅

No test result changes.

Details: https://qlever.dev/sparql-conformance-ui?cur=25f27a44a25d22d3fe36b72c8072a2b754c7064b&prev=a8c9d865aac01c673ffa3b56758a12dbb94f7676

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.11%. Comparing base (a8c9d86) to head (25f27a4).

Files with missing lines Patch % Lines
src/engine/CheckUsePatternTrick.cpp 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
+ Coverage   91.09%   91.11%   +0.01%     
==========================================
  Files         465      465              
  Lines       39690    39694       +4     
  Branches     5312     5313       +1     
==========================================
+ Hits        36155    36166      +11     
+ Misses       2020     2016       -4     
+ Partials     1515     1512       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query Error: "This code should be unreachable" when doing textSearch and grouping

1 participant