Update deprecated macOS runner #2489
Open
+26
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2489 +/- ##
=======================================
Coverage 91.09% 91.09%
=======================================
Files 465 465
Lines 39690 39690
Branches 5312 5312
=======================================
+ Hits 36155 36157 +2
Misses 2020 2020
+ Partials 1515 1513 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobinTF
commented
Nov 6, 2025
.github/workflows/macos.yml
Outdated
| # For std::ranges::join_view we need the -fexperimental-library flag on libc++17, which on Mac requires to manually tinker with the linking flags. | ||
| # We currently cannot use the parallel algorithms, as the parallel sort requires a GNU-extension, and we build with `libc++`. | ||
| run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.build-type}} -DCMAKE_TOOLCHAIN_FILE="$(pwd)/build/conan_toolchain.cmake" -DUSE_PARALLEL=false -DRUN_EXPENSIVE_TESTS=false -DENABLE_EXPENSIVE_CHECKS=true -DCMAKE_CXX_COMPILER=clang++ -DADDITIONAL_COMPILER_FLAGS="-fexperimental-library" -D_NO_TIMING_TESTS=ON -DADDITIONAL_LINKER_FLAGS="-L$(brew --prefix llvm)/lib/c++" | ||
| run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.build-type}} -DCMAKE_TOOLCHAIN_FILE="$(pwd)/build/conan_toolchain.cmake" -DUSE_PARALLEL=false -DRUN_EXPENSIVE_TESTS=false -DENABLE_EXPENSIVE_CHECKS=true -DCMAKE_CXX_COMPILER=clang++ -DADDITIONAL_COMPILER_FLAGS="-fexperimental-library" -D_NO_TIMING_TESTS=ON -DADDITIONAL_LINKER_FLAGS="-L$(brew --prefix llvm@17)/lib/c++" |
There was a problem hiding this comment.
This subtle change gets rid of the warning that is everywhere in the logs: ld: warning: search path '/usr/local/opt/llvm/lib/c++' not found
joka921
reviewed
Nov 6, 2025
Overview
Conformance check passed ✅No test result changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that our builds keep running: actions/runner-images#13046
This has the subtle implication that now the architecture of our macOS build is no longer x86_64, but armv8 instead (there is a macos-runner-15-intel, but it is announced that there won't be one for macos-16, so why not just switch now?).