[DRAFT DRAFT] Write delta triples to dedicated permutations.#2668
Draft
joka921 wants to merge 5 commits intoad-freiburg:masterfrom
Draft
[DRAFT DRAFT] Write delta triples to dedicated permutations.#2668joka921 wants to merge 5 commits intoad-freiburg:masterfrom
joka921 wants to merge 5 commits intoad-freiburg:masterfrom
Conversation
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Complete the TODO in DeltaTriples::rebuildOnDiskDeltas to properly merge existing on-disk delta triples with new in-memory delta triples. Key changes: - Fix metadata persistence: Write metadata to end of delta files following IndexMetaData format (serialize metadata + write offset) - Fix metadata loading: Read offset from file end and deserialize metadata - Add streaming merge: Implement k-way merge with deduplication using priority queue for memory efficiency - Add readAllTriples: Read and combine all blocks from on-disk delta file - Implement complete rebuild logic: Read old on-disk + new in-memory, merge with deduplication, write to temp files, atomic commit - Fix commitTemporaryFiles: Check file existence before renaming The implementation handles both regular and internal permutations, uses atomic writes via temporary files, and fails safely without modifying state if any operation fails. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Overview
Conformance check passed ✅No test result changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.