Use aliasing shared pointers instead of extra lifetime object#2690
Open
RobinTF wants to merge 3 commits intoad-freiburg:masterfrom
Open
Use aliasing shared pointers instead of extra lifetime object#2690RobinTF wants to merge 3 commits intoad-freiburg:masterfrom
RobinTF wants to merge 3 commits intoad-freiburg:masterfrom
Conversation
RobinTF
commented
Feb 2, 2026
Comment on lines
+388
to
+389
| lazyResult = | ||
| std::move(lazyResult)](auto& idTableVocabPair) mutable { |
Collaborator
Author
There was a problem hiding this comment.
I added the lazyResult, because otherwise this result would also go out of scope. Not sure what the consequences would be but just to be safe.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
- Coverage 91.60% 91.59% -0.01%
==========================================
Files 483 483
Lines 41360 41358 -2
Branches 5493 5492 -1
==========================================
- Hits 37886 37881 -5
- Misses 1897 1899 +2
- Partials 1577 1578 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overview
Conformance check failed ❌Test Status Changes 📊
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was originally a suggestion for #2684.
Instead of passing along a vector that makes sure the lifetime of the result objects is extended long enough, we use aliasing shared pointers to achieve the same thing within a single object.