Allow writing materialized views during index build#2693
Open
ullingerc wants to merge 6 commits intoad-freiburg:masterfrom
Open
Allow writing materialized views during index build#2693ullingerc wants to merge 6 commits intoad-freiburg:masterfrom
ullingerc wants to merge 6 commits intoad-freiburg:masterfrom
Conversation
ullingerc
changed the title
qlever-index
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2693 +/- ##
==========================================
- Coverage 91.60% 91.59% -0.01%
==========================================
Files 483 483
Lines 41360 41368 +8
Branches 5493 5495 +2
==========================================
+ Hits 37886 37892 +6
Misses 1897 1897
- Partials 1577 1579 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ullingerc
requested review from
RobinTF and
joka921
and removed request for
RobinTF
Overview
Conformance check failed ❌Test Status Changes 📊
|
|
RobinTF
requested changes
Feb 4, 2026
Collaborator
RobinTF
left a comment
RobinTF
left a comment
There was a problem hiding this comment.
Looks good, just a minor suggestion
| // Helper to convert the JSON given for writing materialized views to a proper | ||
| // `WriteMaterializedViews` vector. | ||
| qlever::IndexBuilderConfig::WriteMaterializedViews parseMaterializedViewsJson( | ||
| std::string materializedViewsJson) { |
Collaborator
There was a problem hiding this comment.
I think using const std::string& or std::string_view should be completely sufficient here, with no change in behaviour for the json parser.
| config.inputFiles_ = getFileSpecifications(filetype, inputFile, | ||
| defaultGraphs, parseParallel); | ||
| config.writeMaterializedViews_ = | ||
| parseMaterializedViewsJson(std::move(materializedViewsJson)); |
Collaborator
There was a problem hiding this comment.
In case you apply my suggestion, you don't need to move here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the possibility to write materialized views during the index build procedure.
Using the
qlever-indexbinary: Specify a JSON mapping from view name to view write queries (e.g.{"geometries": "PREFIX geo: <http://www.opengis.net/ont/geosparql#> SELECT * { ?s geo:hasGeometry ?m . ?m geo:asWKT ?g }"}) with the CLI argument--write-materialized-views.Using
libqlever: Set thewriteMaterializedViews_attribute ofIndexBuilderConfig.