Skip to content

Secrets Cleanup Q-W #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented Apr 10, 2025

These 2 moved out of the root, per request:

  • Minesweep - moved to PyPortal dir no code changes
  • Twitter_API
    • /code.py -> PyPortal/Twitter_API/code.py
    • fonts/Helvetica-Bold-16.bdf -> PyPortal/Twitter_API/fonts/Helvetica-Bold-16.bdf
      • moved
    • twitter_background.bmp -> PyPortal/Twitter_API/twitter_background.bmp
      • moved

And the others:

@justmobilize justmobilize marked this pull request as ready for review April 10, 2025 17:39
@justmobilize
Copy link
Contributor Author

@FoamyGuy This is the last one. Just opening it up for when you have time

Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. I've completed the guide page updates for all the currently checked off ones.

I need to return to the first 2 after merging and update their embed URLs. I'll post another comment here confirming once that is complete.

@FoamyGuy FoamyGuy merged commit 3eaa064 into adafruit:main Apr 16, 2025
4 checks passed
@FoamyGuy
Copy link
Collaborator

The first 2 are now updated to the new embed URLs.

I did also have a look around for the 2 "not found" ones and also came up empty on guides they be long to.

@justmobilize Thank you again for all of the work you've put into making this change! It is very much appreciated.

@justmobilize
Copy link
Contributor Author

Quite welcome.

With a quick mobile search: https://github.com/search?q=repo%3Aadafruit%2FAdafruit_Learning_System_Guides+secrets+language%3APython&type=code&l=Python it appears I got them all.

Will double check next week. I'll have one more PR to update a few legacy AIO keys and then everything should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants