Detect max quality level dynamically. #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect max quality level dynamically. This will select 2 for standard Pico 2's and 5 for standard Pico's.
BlitzCityDIY
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect max quality level dynamically.
This will select 2 for standard Pico 2's and 5 for standard Pico's.
Tested on Pico and Pico 2.
Note that the the code for Adafruit_CircuitPython_OV5640, the acceptable range of the quality says:
"""Controls the JPEG quality. Valid range is from 2..55 inclusive"""However, the value 55 is not included, so grammatically I'd say this is inaccurate.
https://github.com/jerryneedell/Adafruit_CircuitPython_OV5640/blob/main/adafruit_ov5640/__init__.py#L1495
I've adjust my comment in the code to indicate such.