Don't NORETURN MP_WEAK functions #10275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamblor21
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #10274, #10260 added
NORETURNto someMP_WEAKfunctions, which were not alwaysNORETURN. Only theNotImplementedErrorversions of these functions wereNORETURN. This caused crashes.Note there was already one
MP_WEAKNORETURNfunctions,common_hal_socketpool_socketpool_raise_gaierror_noname(), but it always raises, so it's alwaysNORETURN.Tested with #10271 (comment) test script and no longer crashes.