-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python Markdown SuperFences #274
base: main
Are you sure you want to change the base?
Conversation
So SuperFences is an extension for Python Markdown? I feel like it’s ma bit niche to add support for at this time, and more importantly commit to maintaining. You’re free to run your fork, of course, and if others chime in saying they use this then I may be more swayed. |
That's a fair point that it's niche. I'll share a bit why they are useful. I'm using superfences in my own documentation as a way to pass metadata about the code block. I run the code in my markdown docs as tests (inspired by koaning/mktestdocs). The extra metadata helps control the test environment. None of that is relevant for this project, except that I want to keep my docs formatted and need to support superfences. I thought I'd just share my work. I'll get this branch working for my own sake, but feel free to merge if you ever want to support this! |
9d0db61
to
7a359e5
Compare
Hi @maxb2, As requested by @adamchainz on the other issue (#281), I've tried to rebase your fork and update it so that GitHub can update this PR (#274). But it looks like I don't have access. Message from Git when I try to do
Can you please implement the changes? Most of the changes needed should be found on my other PR (#282). Thank you. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
7a359e5
to
e82e9e9
Compare
@chrimaho @adamchainz I've rebased this onto main to prepare for merging. What else would you like to be done? |
Fixes #281.
This supports the brace format in superfences. The blocks are processed the same as normal markdown code blocks. The only difference is the
before
line.TODO
.python
and.py3
in the superfences docs, but there is probably more.)