Skip to content

Fix volume FileName property potentially missing #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Fix volume FileName property potentially missing #921

merged 1 commit into from
Jul 7, 2025

Conversation

Morilli
Copy link
Contributor

@Morilli Morilli commented Jul 6, 2025 •
edited
Loading

If the ReaderOptions has LeaveStreamOpen set (which is set to true by default), the stream used to report a volume's FileName was a NonDisposingStream instead of the originally passed in stream, which never worked.

adamhathcock
adamhathcock approved these changes Jul 7, 2025
View reviewed changes
Copy link
Owner

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adamhathcock adamhathcock merged commit 415f0c6 into adamhathcock:master Jul 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamhathcock adamhathcock adamhathcock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Volume's FileName doesn't work when readerOptions is specified
2 participants
@Morilli @adamhathcock