Fix column resize on header cell using colSpan #2802
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2802 +/- ##
==========================================
+ Coverage 93.05% 94.30% +1.24%
==========================================
Files 40 39 -1
Lines 1268 1265 -3
Branches 405 406 +1
==========================================
+ Hits 1180 1193 +13
+ Misses 88 72 -16
|
This reverts commit d4c1ac1.
nstepien
requested changes
Sep 21, 2022
| if (colSpan === null) return colSpanColumnsWidth; | ||
| for (let index = 1; index < Number(colSpan); index++) { | ||
| // nextElementSibling won't be null as all the colSpan columns are rendered | ||
| colSpanColumnsWidth += currentTarget.nextElementSibling!.getBoundingClientRect().width; |
There was a problem hiding this comment.
This just gets the next column's width, multiple times
- why? the next column is unrelated, it just doesn't work well
currentTarget.nextElementSiblingwill be null when there's no column on the right
There was a problem hiding this comment.
Yeah, this is not correct. I wanted to put this PR back to draft
Co-authored-by: Nicolas Stepien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.