Allow for arbitrary data attributes on upper element #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Spread typesafe div props onto the upper element to allow for any data-attribute to be added to the top level.
|
I just noticed my prettier did a number on this one, I can change that back if you prefer 👍 |
|
Any opinion on this one at all? @nstepien @amanmahajan7 It would be super useful in my current project to target the multiple tables I have per page (rather than relying on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, this could also handle all of the aria tags as well by spreading the props but I was more concerned with adding arbitrary data-attributes over refactoring anything too heavily. This is to primarily allow for other tags such as
data-cyfor Cypress recommended naming selectors and to not require a specific prop fordata-testid. The TS types for theDivelement also prevent incorrect attributes being added: