Add support for React 19 #3545
Merged
Add support for React 19 #3545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3545 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 47 47
Lines 3314 3314
Branches 720 719 -1
=======================================
Hits 3229 3229
Misses 85 85
|
amanmahajan7
approved these changes
Jul 15, 2024
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
* Add support for React 19 * react ci matrix * --allow-unrelated-histories * set up git user * log diff with main * merge website job into test job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes required to support both React 18 and React 19.
CI has been updated to run in a React 18 and React 19 matrix.
React 19 is tested by merging the
react19branch before running steps. Not sure if there's a better way.The website job has been merged into the test job to simplify things, building the website only takes 9s anyway.
Removed CI cache usage, it seems fast enough without it.