Improve browser tests #3547
Merged
Improve browser tests #3547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
commented
Jul 16, 2024
test/copyPaste.test.tsx
Outdated
| expect(getSelectedCell()).not.toHaveClass(copyCellClassName); | ||
| expect(onCopySpy).not.toHaveBeenCalled(); | ||
| await userEvent.keyboard('{arrowdown}'); | ||
| pasteSelectedCell(); | ||
| await userEvent.keyboard('{enter}{arrowdown}'); |
There was a problem hiding this comment.
Enter closes the editor
There was a problem hiding this comment.
Why is the editor open at this point?
There was a problem hiding this comment.
I forgot about this change. I thought the empty cell was the editor. I will investigate
There was a problem hiding this comment.
It is actually the paste operation that triggers the editor. Also, escape does not work with null editor
nstepien
approved these changes
Jul 18, 2024
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
- Use Vitest helpers to simulate copy/paste - Remove `scrollIntoView` mock and check grid position instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vitesthelpers to simulate copy/pastescrollIntoViewmock and check grid position instead