Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message #3672

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Better error message #3672

merged 2 commits into from
Dec 17, 2024

Conversation

amanmahajan7
Copy link
Contributor

Fixes #3597

@amanmahajan7 amanmahajan7 self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.47%. Comparing base (011e1f9) to head (8fa5575).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hooks/useRowSelection.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3672      +/-   ##
==========================================
- Coverage   93.89%   92.47%   -1.42%     
==========================================
  Files          48       48              
  Lines        3455     3455              
  Branches      698      684      -14     
==========================================
- Hits         3244     3195      -49     
- Misses        211      260      +49     
Files with missing lines Coverage Δ
src/hooks/useRowSelection.ts 89.18% <0.00%> (ø)

... and 7 files with indirect coverage changes

@amanmahajan7 amanmahajan7 marked this pull request as ready for review December 16, 2024 22:41
@amanmahajan7 amanmahajan7 merged commit 38c6284 into main Dec 17, 2024
3 checks passed
@amanmahajan7 amanmahajan7 deleted the am-tweak-error branch December 17, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: useRowSelection must be used within DataGrid cells bunping 7.0.0-beta.44 => 7.0.0-beta.47
2 participants