Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow #25

Open
wants to merge 94 commits into
base: master
Choose a base branch
from
Open

Flow #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
bbf87c8
added flow, and travis
Feb 5, 2015
3bdaaf4
kick travis
Feb 5, 2015
1ba5021
try out hound
Feb 5, 2015
8ccd910
try travis + flow..
Feb 5, 2015
df7aa00
fix flow files ref
Feb 5, 2015
0663624
mroe @flows
Feb 5, 2015
80c28fd
using manual flow task for now, need to work out whats up with flow f…
Feb 5, 2015
c1a0675
kill lib-compiled, remove @copyright
Feb 6, 2015
b775a63
Missed api files
Feb 6, 2015
f5ffc74
flow nearly done. mixins not recognised, but otherwise looking good.
Feb 9, 2015
c87d27f
flow working... 14 files ignored
Feb 9, 2015
7cc45f6
local flow gulp config
Feb 9, 2015
49569ba
flow on examples too
Feb 9, 2015
0b4b724
adding in proptypes addons/cells done
Feb 9, 2015
5a1a143
flow with prop types done, now to see how much I broke
Feb 9, 2015
6da45c9
main example working, editable not
Feb 9, 2015
e7ba296
fixup flow errors
Feb 9, 2015
ccf1d23
flkow and examples working, gulp tasks updated / cleaned up
Feb 10, 2015
382a4d3
listen to keyboard events at grid level instead of cell level
malonecj Feb 19, 2015
66e1754
keyboard scroll performance improvements
malonecj Feb 19, 2015
b61e478
moving editor mixin functionality into selectable mixin
malonecj Feb 19, 2015
08556ca
fixed editing
malonecj Feb 20, 2015
1f4fa8f
rename lib -> libs so we dont gitignore it
Feb 23, 2015
088bd7c
split up flow/libs files
Feb 23, 2015
f7f305e
run flow after build
Feb 23, 2015
6ae326b
revert that..
Feb 23, 2015
7d92998
and add back the examples page
Feb 23, 2015
49d0600
add flow to examples
Feb 23, 2015
200f602
get flow working down to row
Feb 23, 2015
6823c39
got to header ~ 12 to go
Feb 23, 2015
5ebe4b1
flow, nearly all done
Feb 24, 2015
c1d67e7
catchup master
Feb 24, 2015
1cc374c
caught up and flowing
Feb 24, 2015
aa0e027
catch up with cm-perf
Feb 24, 2015
b88ec5d
close to being flowed
Feb 24, 2015
444a345
fun flow-in, get 0 errors => WIN
Feb 24, 2015
3a2a94b
flow win on appveyor (with deliberate error)
Feb 24, 2015
a6aeee1
move flow-win ahead of tests (which dont work, but dont fail the build)
Feb 24, 2015
5df91fa
move off deprecated clean package
Feb 24, 2015
194c09b
fixup webpack
Feb 24, 2015
84ee08b
webpack errors
Feb 25, 2015
edfd9e5
fix deliberate mistake..
Feb 25, 2015
9dfcc09
change headerrow to class
malonecj Feb 25, 2015
0103871
fix headerRow style error
malonecj Feb 25, 2015
1a290bf
Set ReactGrid to be library route for both basic and addons files
malonecj Feb 26, 2015
5a52dbd
use class instead of flow types in PropType validation
malonecj Feb 26, 2015
1ef182e
report webpack error handling when building dist files
malonecj Feb 26, 2015
1ad21be
add dist files
malonecj Feb 26, 2015
8c3a9c9
simplify gulp build process
malonecj Feb 26, 2015
c4ebe4f
mix keyboard functionality to selectable grid mixin
malonecj Feb 26, 2015
3fc5d55
delete unnecessary gulp tasks
malonecj Feb 26, 2015
5bfa6e1
enable header row to scroll with grid
malonecj Feb 26, 2015
34d11a7
fix view port scroll left issue
malonecj Feb 26, 2015
bf125ce
change column row definition in excel example
malonecj Feb 26, 2015
b771e26
added ImageFormatter component and example
malonecj Feb 26, 2015
3040128
remove selected class when cell is active
malonecj Feb 26, 2015
88780b3
sort out gulp dist task and add flow by default
Feb 26, 2015
e7b08b5
fixup flow
Feb 26, 2015
baa7ae5
increase keyboard scrolling some more
malonecj Feb 26, 2015
b579aa2
fix propType typo
malonecj Feb 26, 2015
6f8fd1c
fix missing require
malonecj Feb 26, 2015
f15c20a
check in dist files
malonecj Feb 27, 2015
037dd8e
add jshint and fix some flow errors
Feb 28, 2015
e074a1b
consolidate all cell mixins into cell.js
malonecj Mar 2, 2015
897e984
ignore dist folder, means need a more advanced bower build though
Mar 2, 2015
bae26a0
Move all editor mixin functionality into Editor Container component
malonecj Mar 2, 2015
328dff5
remove overcomplicated Mixin helper functionality
malonecj Mar 2, 2015
0a91b60
pull from remote branch
malonecj Mar 2, 2015
50c700b
EditorContainer now correctly handles editor updates for simpleTextEd…
malonecj Mar 2, 2015
47df623
remove prop type for rows significantly speeds up onCommit time
malonecj Mar 2, 2015
a8f92af
use latest version of node
Mar 3, 2015
e519f6e
shallow clone
Mar 3, 2015
da12eb5
couple of flow fixes, still a few to go
Mar 3, 2015
a1cb62a
EditorContainer flowing
Mar 3, 2015
85b26bd
Have EditorContainer implement Editor getValue()
malonecj Mar 3, 2015
1063974
pull remote changes and fix conflicts
malonecj Mar 3, 2015
c585b9e
Autocomplete working again with all keyboard functionality in editor …
malonecj Mar 3, 2015
76de443
editor tidy up
malonecj Mar 3, 2015
24a1908
more editor tidy up
malonecj Mar 3, 2015
f85f5a3
fix flow errors
malonecj Mar 3, 2015
5b3e738
fixup some flows
Mar 3, 2015
a2356c5
dropdown editor working again
malonecj Mar 3, 2015
20ccf62
fix flow errors
malonecj Mar 3, 2015
de8fa41
use minified react version
malonecj Mar 3, 2015
ddb4c2c
add editor declaration
Mar 3, 2015
a5a0bb7
start of getting editors to be typed
Mar 3, 2015
80f4173
typing of editor
Mar 4, 2015
cf1fccb
Add better typing for columns
Mar 4, 2015
576c8d8
move all grid mixin functionlity into excel grid and deleted mixin fu…
malonecj Mar 5, 2015
c0cf136
fix up cell copy
malonecj Mar 5, 2015
cc7187d
fixing all the broken stuff
malonecj Mar 5, 2015
e797361
fix add row
malonecj Mar 5, 2015
55adcd0
fix filter cells
malonecj Mar 5, 2015
ad5d693
add drag classes
malonecj Mar 5, 2015
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .appveyor.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
version: 1.0.{build}
environment:
COVERALLS_REPO_TOKEN: ab4LZQwXbVRwQIn0MEHqaaOjidqu78RFQ
COVERALLS_SERVICE_NAME: appveyor
shallow_clone: true
build_script:
- ps: >-
Install-Product node 0.12.0 x64

npm install -g gulp

npm cache clean

npm install

gulp flow-win

gulp test --release

gulp coveralls
4 changes: 4 additions & 0 deletions .flowconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[include]
./node_modules/immutable
./node_modules/react
./src
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ bower_components
lib
**/build
test/reports
dist
2 changes: 1 addition & 1 deletion addons.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require("./dist/ReactGridAddons");
module.exports = require("./dist/ReactGridWithAddons");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'require' is not defined.

42 changes: 42 additions & 0 deletions config/webpack.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
var path = require("path");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'require' is not defined.

var webpack = require('webpack');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.
'require' is not defined.

var release = false;
var path = require("path");

module.exports = {
entry: {
'ReactGrid' : './src/index',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

'ReactGridWithAddons' : './src/addons/index'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

},
output: {
path: path.join(__dirname, "../dist"),
filename: "[name].js",
library: ["ReactGrid"],
libraryTarget: "umd"
},
externals: {
"react/addons": {
root : 'React',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

commonjs : 'react/addons',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

commonjs2 : 'react/addons',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

amd : 'react/addons'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

},
"moment" : "moment"
},
module: {
loaders: [
{ test: /\.js$/, loader: 'jsx-loader?stripTypes&harmony' } // loaders can take parameters as a querystring

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.
Mixed double and single quotes.

]
},
plugins: [
new webpack.optimize.DedupePlugin(),
new webpack.optimize.OccurenceOrderPlugin(),
new webpack.optimize.AggressiveMergingPlugin()
],
postLoaders: [
{
test: /\.js$/,
exclude: /node_modules|testData/,
loader: 'jshint'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

}]
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

Loading