Issue 4779 - Application name wraps when displayed in app drawer #1
Conversation
res/values/strings.xml
Outdated
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <resources> | |||
|
|
|||
| <string name="app_name">Adblock Plus for Samsung Internet</string> | |||
| <string name="app_name">Adblock Plus</string> | |||
There was a problem hiding this comment.
We still want to keep the current naming for the MainPreferences activity. Given that, instead of modifying the app_name string, we need to add a new item <string name="launcher_name">Adblock Plus</string> and use it in the application label on AndroidManifest.xml
There was a problem hiding this comment.
That is a good point. I will make the changes.
| @@ -1,7 +1,8 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <resources> | |||
|
|
|||
| <string name="app_name">Adblock Plus</string> | |||
| <string name="app_name">Adblock Plus for Samsung Internet</string> | |||
| <string name="launcher_name">Adblock Plus</string> | |||
There was a problem hiding this comment.
Just one more thing, you need to use this launcher_name string in AndroidManifest. Under the <application> tag, change the label to android:label="@string/launcher_name"
There was a problem hiding this comment.
Thank you for your continued guidance Diego! I have updated AndroidManifest.
|
LGTM after Diego's changes taken into account |
|
Hey @fseto, before we push your patch, we need you to sign the contributor agreement. Let me know if you have any questions. Cheers! |
Issue #1 - Migrate to default Android project structure See merge request eyeo/adblockplus/adblockplussbrowser!4
https://issues.adblockplus.org/ticket/4779