Factory pattern code example bug removal #227
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Behaviour
Since the default values were set for the factory method i.e, Car constructor, if user did not pass any arguments at all i.e,
it should create a Car object with default values. which would result in this object
Car { doors: 6, state: 'brand new', color: 'yellow' }
but instead it throws an error because if nothing is passed options will be
undefined
.Correction
we set the default value of
options
to an empty object. It will then allow assigning all of the default values