Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1624. Search for the image in the page resources. #1651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valnaumov
Copy link

Fixes image URL for multilingual sites when the image resource is only defined for the default language.

What does this PR change? What problem does it solve?

PaperMod defines a custom figure shortcode which currently fails to provide a valid link in a multilingual site. As stated in Hugo docs, we should be able to use image resources from any page bundle.

The old shortcode uses the img src as is without searching for the resource in other page bundles. See the linked issue for an example.

Was the change discussed in an issue or in the Discussions before?

Closes #1624

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Fixes image URL for multilingual sites when the image resource is only defined for the default language.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: figure short code is not working properly for multilingual websites
1 participant