Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social icon for Jamendo #1685

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

massimobarbieri
Copy link
Contributor

@massimobarbieri massimobarbieri commented Feb 25, 2025

What does this PR change? What problem does it solve?

Was the change discussed in an issue or in the Discussions before?

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the colors, it should use currentColor to fill in the theme's current color.

@pepev-nrt
Copy link
Contributor

I've cleaned the code:

{{- else if (eq $icon_name "jamendo") -}}
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="1.3">
    <path style="stroke-width:1.7"
        d="M 11.953964,1.9577206 C 8.9486891,3.6582881 5.9434143,5.3588555 2.9381394,7.059423 c 0,3.325368 0,6.650735 0,9.976103 2.9643942,1.765865 5.9287884,3.531729 8.8931826,5.297594 3.002478,-1.73905 6.004955,-3.478101 9.007433,-5.217151 0,-3.360254 0,-6.720509 0,-10.0807628 C 17.877158,5.342711 14.915561,3.6502158 11.953964,1.9577206 Z" />
     <path d="M 6.7394985,14.712082 8.3520207,11.408709" />
     <path d="M 9.2716212,14.767353 11.902927,9.4304828" />
     <path d="M 13.170768,11.935987 14.59425,9.3677519" />
     <path d="M 14.54983,14.574583 17.177574,9.4459113" />

@pepev-nrt
Copy link
Contributor

Not it's like this:
image

Copy link

sonarqubecloud bot commented Mar 1, 2025

@adityatelange adityatelange merged commit fd10e80 into adityatelange:master Mar 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants