Remove outdated dependency junit-addons#1314
Open
stefanseifert wants to merge 1 commit intoadobe:developfrom
Open
Remove outdated dependency junit-addons#1314stefanseifert wants to merge 1 commit intoadobe:developfrom
stefanseifert wants to merge 1 commit intoadobe:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remove this dependency from parent POM and core module:
Related Issue
Fixes #920
Motivation and Context
this dependency is completely outdated (more than 20 years old!!), it's not compatible/usable with JUnit 5+, and even worse, it breaks JSON content loading when using AEM mocks, as it injects an outdated Xerces version into the test build classpath (as described in #920). it should be removed without replacement.
How Has This Been Tested?
the archetype build including its ITs is passing without this dependency.