Skip to content

fix: ACNA-2967 - web actions and web sequences with the same name can be deployed, web action implementation is unreachable #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024

Conversation

shazron
Copy link
Member

@shazron shazron commented May 27, 2024

Fixes adobe/aio-cli#614

How Has This Been Tested?

npm test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

… be deployed, web action implementation is unreachable
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4cec293) to head (9dd8a59).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #190   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1303      1308    +5     
  Branches       346       348    +2     
=========================================
+ Hits          1303      1308    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron merged commit da90917 into master May 29, 2024
8 checks passed
@shazron shazron deleted the story/ACNA-2967 branch May 29, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web actions and web sequences with the same name can be deployed, web action implementation is unreachable
3 participants