Skip to content

Conversation

@tmastalirsch-tlv
Copy link
Contributor

Internationalize Search Result Components for Better Multilingual Support

Description

This pull request contains internationalization improvements to the Asset Share Commons search components:

Commit 1: feat: internationalize table headers in search results and sort components

  • Added internationalization support to table headers in list template (list.html)
  • Internationalized sort component labels in (sort.html)

Commit 2: fix: internationalize asset type display in search results card

  • Fixed asset type display internationalization in card template (card.html)

These changes ensure that all user-facing text in search components can be properly translated using AEM's i18n framework, making the Asset Share Commons more accessible for international users.

Related Issue

N/A - Component improvements and maintenance

Motivation and Context

These changes address the need for better multilingual support in Asset Share Commons by:

  • Making hardcoded English text translatable through AEM's i18n framework
  • Ensuring consistent internationalization across all search result display formats (list and card views)
  • Following AEM best practices for component internationalization
  • Improving accessibility for non-English speaking users

Files modified:

  • ui.apps/.../search/results/result/list/templates/list.html - Table headers internationalization
  • ui.apps/.../search/sort/sort.html - Sort component labels internationalization
  • ui.apps/.../search/results/result/card/templates/card.html - Asset type display internationalization

How Has This Been Tested?

  • Verified i18n expressions are properly formatted (@ i18n)
  • Tested that hardcoded text has been replaced with translation keys
  • Confirmed list view table headers display correctly
  • Tested card view asset type display internationalization
  • Verified sort component labels are translatable
  • Tested component functionality remains intact after i18n changes
  • Confirmed backward compatibility with existing translations

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue) - Fixed missing i18n support
  • New feature (non-breaking change which adds functionality) - Added internationalization support
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@davidjgonzalez davidjgonzalez merged commit fdb1649 into adobe:develop Sep 19, 2025
3 of 4 checks passed
@tmastalirsch-tlv tmastalirsch-tlv deleted the feature/search-component-updates branch September 22, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants