Skip to content

ci(github): release changes to github, in dedicated release branches, so that they can be synced to code bus #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

trieloff
Copy link
Contributor

this is a step towards using helix as a backend for script delivery instead of unpkg or jsdelivr.
for each release, we create or update three branches:
release-2-34-3 for the exact version number
release-2-34-x for the minor version
release-2-x for the major version

once this has been merged, and once the helix bot has been activated for the repo again, we will be able to use helix as the backend for newer versions in helix-rum-collector

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • package.json: Language not supported
  • tagger.sh: Language not supported
Comments suppressed due to low confidence (2)

.releaserc.cjs:9

  • Verify that the tagger.sh script is executable and available in the correct location, as failing to do so could cause the publish command to fail.
["@semantic-release/exec", {

.github/workflows/main.yaml:41

  • Ensure that the specified token (ADOBE_BOT_GITHUB_TOKEN) has the appropriate permissions for the required operations when credentials are persisted.
persist-credentials: true

@trieloff
Copy link
Contributor Author

I've re-enabled the AEM Code Sync

@kptdobe
Copy link
Contributor

kptdobe commented Apr 10, 2025

Why not using proper Github tags instead of creating branches ?
See https://release-2-x--hlxplayground--kptdobe.hlx.live/scripts/scripts.js

@kptdobe
Copy link
Contributor

kptdobe commented Apr 10, 2025

Minor for now: we'll also need to revert c0885ef to re-enable the ignore-psi-check label and not be annoyed by the renovate PRs on dev dependencies.

@trieloff
Copy link
Contributor Author

Two reasons to use branches

  1. I thought that tags were not synchronized into code bus
  2. So that we can push additional files onto the branch, but this is only needed for rum-enhancer

Copy link

This PR will trigger a patch release when merged.

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9e56efa) to head (7c6f137).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #258   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          187       187           
=========================================
  Hits           187       187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kptdobe
Copy link
Contributor

kptdobe commented Apr 10, 2025

(the ignore-psi-check label only works when added by a bot AND when PR is created - to avoid devs abusing it to skip the tests).

@trieloff trieloff merged commit d62772d into main Apr 11, 2025
7 of 8 checks passed
@trieloff trieloff deleted the taggerle branch April 11, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants