-
Notifications
You must be signed in to change notification settings - Fork 8
ci(github): release changes to github, in dedicated release branches, so that they can be synced to code bus #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… so that they can be synced to code bus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- package.json: Language not supported
- tagger.sh: Language not supported
Comments suppressed due to low confidence (2)
.releaserc.cjs:9
- Verify that the tagger.sh script is executable and available in the correct location, as failing to do so could cause the publish command to fail.
["@semantic-release/exec", {
.github/workflows/main.yaml:41
- Ensure that the specified token (ADOBE_BOT_GITHUB_TOKEN) has the appropriate permissions for the required operations when credentials are persisted.
persist-credentials: true
I've re-enabled the AEM Code Sync |
Why not using proper Github tags instead of creating branches ? |
Minor for now: we'll also need to revert c0885ef to re-enable the |
Two reasons to use branches
|
This reverts commit c0885ef.
This PR will trigger a patch release when merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 187 187
=========================================
Hits 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
(the |
this is a step towards using helix as a backend for script delivery instead of unpkg or jsdelivr.
for each release, we create or update three branches:
release-2-34-3 for the exact version number
release-2-34-x for the minor version
release-2-x for the major version
once this has been merged, and once the helix bot has been activated for the repo again, we will be able to use helix as the backend for newer versions in helix-rum-collector