feat: no reload #660
Draft
feat: no reload #660
+126
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
|
@kptdobe the code doesn't fetch the data when you increase the range (week to month or month to year). rum.mov |
vdua
reviewed
Sep 25, 2024
trieloff
approved these changes
Oct 14, 2024
Contributor
Author
|
Not merging for now as this is not crucial. But I am looking at selection gesture on the chart to "drill down" in the period, having a client side refresh will make the experience much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why reloading the full page while a simple redraw should do the job and avoid the flicker.
Redrawing might require to fetch a different set of data if the
view,startDateorendDateis changed.I noticed also that when there are a lot of data to fetch (like 1GB when loading adobe.com week view), the UI might feel unresponsive. I have added a loading spinner and disabled all facets.
https://no-reload--helix-website--adobe.aem.live/tools/rum/explorer.html?domain=www.adobe.com