Update github actions #46
Conversation
cmake/recipes/external/eigen.cmake
Outdated
| # Bypass the following GCC bug. | ||
| # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106247 | ||
| target_compile_options(Eigen3_Eigen INTERFACE | ||
| "-Wno-array-bounds" |
There was a problem hiding this comment.
Same here I'm tempted to use the warnoff/warnon mechanism rather than having this flag spill into our own codebase. But given how widely we use Eigen that sounds really annoying...
There was a problem hiding this comment.
I am a bit worried about this due to exactly this reason, but it is worth a try.
There was a problem hiding this comment.
One option would be to use a "proxy" header to fence the include with warnoff/warnon. We can have one proxy header for Dense/Sparse/Geometry.
Do you know if the warning is triggered when the template is instantiated? (in our own codebase), or when the header is parsed (i.e. inside the Eigen header)?
There was a problem hiding this comment.
This is triggered in our own code.
There was a problem hiding this comment.
Ok it seems that this warning is unreliable with gcc. Let's add it as a PRIVATE warning in the main Lagrange targets then (e.g. when we define our target via lagrange_add_module()), to avoid spilling out into client code.
There was a problem hiding this comment.
Can you take a look at 0aca2cb? It seems there are only a few places that triggers this warning, and we can put warning ignore guards around those places.
Summary:
manylinux_2_28image.