-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Icon builder to library #8203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -222,6 +223,9 @@ | |||
"@babel/preset-env": "7.24.4", | |||
"@babel/traverse": "7.24.1", | |||
"@babel/types": "7.24.0", | |||
"@parcel/transformer-react-refresh-wrap": "2.14.0", | |||
"@parcel/transformer-js": "2.14.0", | |||
"@parcel/codeframe": "2.14.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
@@ -16,6 +16,28 @@ const path = require('path'); | |||
module.exports = new Namer({ | |||
name({bundle}) { | |||
let mainAsset = bundle.getMainEntry(); | |||
|
|||
if (!mainAsset?.filePath.includes('react-spectrum/packages')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same logic as below? Could the if conditions be merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, so open question about this due to ask for non-20 sized icons
I had it originally separate though as a reminder to see if there was a better condition we could use
@@ -0,0 +1,42 @@ | |||
# Parcel example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a different readme?
Closes
Adds an option to our icon builder so that users can build a library of icons more easily with the same processing we apply to our own S2 Icon library.
To run the new option, create a new npm project with an appropriate package.json, such as
Copy your svg icons into a
src
directory in the project.Then run
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the last commit with a comment on it, check out the new artifact S2 Custom Icons
There should be an action button with an AlignRight icon in it.
🧢 Your Project: