Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove lighthouse redundancy in pipeline #5182

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

Rajdeepc
Copy link
Contributor

Description

This PR removes redundant Lighthouse checks from the CI pipeline to optimize build times and reduce unnecessary executions. Lighthouse audits were being run multiple times, leading to redundant checks without added value. This change ensures that performance and accessibility tests are still covered without the extra overhead.

Motivation and context

Removing redundant Lighthouse runs helps streamline our CI pipeline, improving efficiency and reducing execution time without impacting the quality of our audits.

How has this been tested?

  • Verified that the pipeline runs successfully without the redundant Lighthouse steps.
  • Ensured that other CI checks, including performance and accessibility tests, continue to function correctly.
  • Checked logs to confirm that necessary audits are still performed where required.

Types of changes

  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

Let me know if you need any modifications! 🚀

@Rajdeepc Rajdeepc self-assigned this Mar 11, 2025
@Rajdeepc Rajdeepc requested a review from a team as a code owner March 11, 2025 11:50
Copy link

changeset-bot bot commented Mar 11, 2025

⚠️ No Changeset found

Latest commit: 716fb1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

Tachometer results

Currently, no packages are changed by this PR...

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13787310318

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.977%

Totals Coverage Status
Change from base Build 13763875714: 0.0%
Covered Lines: 33650
Relevant Lines: 34148

💛 - Coveralls

Copy link
Contributor

@rubencarvalho rubencarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's revisit performance testing in the future, in a more relevant way.

@Rajdeepc Rajdeepc merged commit 93744eb into main Mar 11, 2025
23 of 26 checks passed
@Rajdeepc Rajdeepc deleted the rajdeep/remove-lighthouse branch March 11, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants