Skip to content

chore: update dependency @spectrum-css/dialog to v12.1.0 #5304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+40 −208
Open

chore: update dependency @spectrum-css/dialog to v12.1.0 #5304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92bd182
chore: update dependency @spectrum-css/dialog to v11.0.1
renovate[bot] Mar 31, 2025
6a2dcab
fix(dialog,styles): use latest CSS
castastrophe Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dialog/package.json
View file
Original file line number Diff line number Diff line change
@@ -91,7 +91,7 @@
"@spectrum-web-components/underlay": "1.5.0"
},
"devDependencies": {
"@spectrum-css/dialog": "11.0.0-s2-foundations.15"
"@spectrum-css/dialog": "12.1.0"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
58 changes: 0 additions & 58 deletions packages/dialog/src/dialog-overrides.css
View file
Original file line number Diff line number Diff line change
@@ -11,61 +11,3 @@ governing permissions and limitations under the License.
*/

/* THIS FILE IS MACHINE GENERATED. DO NOT EDIT */
:host {
--spectrum-dialog-fullscreen-header-text-size: var(
--system-dialog-fullscreen-header-text-size
);
--spectrum-dialog-min-inline-size: var(--system-dialog-min-inline-size);
--spectrum-dialog-confirm-small-width: var(
--system-dialog-confirm-small-width
);
--spectrum-dialog-confirm-medium-width: var(
--system-dialog-confirm-medium-width
);
--spectrum-dialog-confirm-large-width: var(
--system-dialog-confirm-large-width
);
--spectrum-dialog-confirm-divider-block-spacing-start: var(
--system-dialog-confirm-divider-block-spacing-start
);
--spectrum-dialog-confirm-divider-block-spacing-end: var(
--system-dialog-confirm-divider-block-spacing-end
);
--spectrum-dialog-confirm-description-text-color: var(
--system-dialog-confirm-description-text-color
);
--spectrum-dialog-confirm-title-text-color: var(
--system-dialog-confirm-title-text-color
);
--spectrum-dialog-confirm-description-text-line-height: var(
--system-dialog-confirm-description-text-line-height
);
--spectrum-dialog-confirm-title-text-line-height: var(
--system-dialog-confirm-title-text-line-height
);
--spectrum-dialog-heading-font-weight: var(
--system-dialog-heading-font-weight
);
--spectrum-dialog-confirm-description-padding: var(
--system-dialog-confirm-description-padding
);
--spectrum-dialog-confirm-description-margin: var(
--system-dialog-confirm-description-margin
);
--spectrum-dialog-confirm-footer-padding-top: var(
--system-dialog-confirm-footer-padding-top
);
--spectrum-dialog-confirm-gap-size: var(--system-dialog-confirm-gap-size);
--spectrum-dialog-confirm-buttongroup-padding-top: var(
--system-dialog-confirm-buttongroup-padding-top
);
--spectrum-dialog-confirm-close-button-size: var(
--system-dialog-confirm-close-button-size
);
--spectrum-dialog-confirm-close-button-padding: var(
--system-dialog-confirm-close-button-padding
);
--spectrum-dialog-confirm-divider-height: var(
--system-dialog-confirm-divider-height
);
}
1 change: 0 additions & 1 deletion packages/dialog/src/dialog.css
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@ governing permissions and limitations under the License.
*/

@import url('./spectrum-dialog.css');
@import url('./dialog-overrides.css');

:host {
--swc-alert-dialog-error-icon-color: var(--spectrum-negative-visual-color);
43 changes: 25 additions & 18 deletions packages/dialog/src/spectrum-dialog.css
View file
Original file line number Diff line number Diff line change
@@ -12,25 +12,31 @@ governing permissions and limitations under the License.

/* THIS FILE IS MACHINE GENERATED. DO NOT EDIT */
:host {
--spectrum-dialog-confirm-divider-block-spacing-start: var(--spectrum-spacing-300);
--spectrum-dialog-confirm-divider-block-spacing-end: var(--spectrum-spacing-200);
--spectrum-dialog-confirm-description-text-color: var(--spectrum-gray-800);
--spectrum-dialog-confirm-description-padding: var(--spectrum-spacing-50);
--spectrum-dialog-confirm-gap-size: var(--spectrum-component-pill-edge-to-text-100);
--spectrum-dialog-confirm-buttongroup-padding-top: var(--spectrum-spacing-600);
--spectrum-dialog-confirm-close-button-size: var(--spectrum-component-height-100);
--spectrum-dialog-confirm-close-button-padding: calc(26px - var(--spectrum-component-bottom-to-text-300));
box-sizing: border-box;
inline-size: fit-content;
min-inline-size: var(--mod-dialog-min-inline-size, var(--spectrum-dialog-min-inline-size));
inline-size: 480px;
inline-size: var(--mod-dialog-width, var(--mod-dialog-confirm-medium-width, 480px));
min-inline-size: 288px;
min-inline-size: var(--mod-dialog-min-inline-size, 288px);
max-inline-size: 100%;
max-block-size: inherit;
outline: none;
display: flex;
}

:host([size='s']) {
inline-size: var(--mod-dialog-confirm-small-width, var(--spectrum-dialog-confirm-small-width));
.spectrum-Dialog--sizeS {
--mod-dialog-width: var(--mod-dialog-confirm-small-width, 400px);
}

:host([size='m']) {
inline-size: var(--mod-dialog-confirm-medium-width, var(--spectrum-dialog-confirm-medium-width));
}

:host([size='l']) {
inline-size: var(--mod-dialog-confirm-large-width, var(--spectrum-dialog-confirm-large-width));
.spectrum-Dialog--sizeL {
--mod-dialog-width: var(--mod-dialog-confirm-large-width, 640px);
}

::slotted([slot='hero']) {
@@ -60,9 +66,9 @@ governing permissions and limitations under the License.

::slotted([slot='heading']) {
font-size: var(--mod-dialog-confirm-title-text-size, var(--spectrum-dialog-confirm-title-text-size));
font-weight: var(--mod-dialog-heading-font-weight, var(--spectrum-dialog-heading-font-weight));
line-height: var(--mod-dialog-confirm-title-text-line-height, var(--spectrum-dialog-confirm-title-text-line-height));
color: var(--mod-dialog-confirm-title-text-color, var(--spectrum-dialog-confirm-title-text-color));
font-weight: var(--mod-dialog-heading-font-weight, var(--spectrum-heading-sans-serif-font-weight));
line-height: var(--mod-dialog-confirm-title-text-line-height, var(--spectrum-line-height-100));
color: var(--mod-dialog-confirm-title-text-color, var(--spectrum-gray-900));
outline: none;
grid-area: heading;
margin: 0;
@@ -99,18 +105,18 @@ governing permissions and limitations under the License.
}

:host([no-divider]) ::slotted([slot='heading']) {
padding-block-end: calc(var(--mod-dialog-confirm-divider-block-spacing-end, var(--spectrum-dialog-confirm-divider-block-spacing-end)) + var(--mod-dialog-confirm-divider-block-spacing-start, var(--spectrum-dialog-confirm-divider-block-spacing-start)) + var(--mod-dialog-confirm-divider-height, var(--spectrum-dialog-confirm-divider-height)));
padding-block-end: calc(var(--mod-dialog-confirm-divider-block-spacing-end, var(--spectrum-dialog-confirm-divider-block-spacing-end)) + var(--mod-dialog-confirm-divider-block-spacing-start, var(--spectrum-dialog-confirm-divider-block-spacing-start)) + var(--mod-dialog-confirm-divider-height, var(--spectrum-spacing-50)));
}

.content {
box-sizing: border-box;
-webkit-overflow-scrolling: touch;
font-size: var(--mod-dialog-confirm-description-text-size, var(--spectrum-dialog-confirm-description-text-size));
font-weight: var(--mod-dialog-confirm-description-font-weight, var(--spectrum-regular-font-weight));
line-height: var(--mod-dialog-confirm-description-text-line-height, var(--spectrum-dialog-confirm-description-text-line-height));
line-height: var(--mod-dialog-confirm-description-text-line-height, var(--spectrum-line-height-100));
color: var(--mod-dialog-confirm-description-text-color, var(--spectrum-dialog-confirm-description-text-color));
padding: calc(var(--mod-dialog-confirm-description-padding, var(--spectrum-dialog-confirm-description-padding)) * 2);
margin: 0 var(--mod-dialog-confirm-description-margin, var(--spectrum-dialog-confirm-description-margin));
margin: 0 var(--mod-dialog-confirm-description-margin, calc(var(--spectrum-spacing-50) * -1));
outline: none;
grid-area: content;
overflow-y: auto;
@@ -120,7 +126,7 @@ governing permissions and limitations under the License.
outline: none;
flex-wrap: wrap;
grid-area: footer;
padding-block-start: var(--mod-dialog-confirm-footer-padding-top, var(--spectrum-dialog-confirm-footer-padding-top));
padding-block-start: var(--mod-dialog-confirm-footer-padding-top, var(--spectrum-spacing-600));
display: flex;
}

@@ -202,7 +208,8 @@ governing permissions and limitations under the License.

:host([mode='fullscreen']) ::slotted([slot='heading']),
:host([mode='fullscreenTakeover']) ::slotted([slot='heading']) {
font-size: var(--mod-dialog-fullscreen-header-text-size, var(--spectrum-dialog-fullscreen-header-text-size));
font-size: 28px;
font-size: var(--mod-dialog-fullscreen-header-text-size, 28px);
}

:host([mode='fullscreen']) .content,
40 changes: 0 additions & 40 deletions tools/styles/tokens-v2/system-theme-bridge.css
View file
Original file line number Diff line number Diff line change
@@ -685,46 +685,6 @@
--system-combobox-border-color-disabled: var(
--spectrum-disabled-border-color
);
--system-dialog-fullscreen-header-text-size: 28px;
--system-dialog-min-inline-size: 288px;
--system-dialog-confirm-small-width: 400px;
--system-dialog-confirm-medium-width: 480px;
--system-dialog-confirm-large-width: 640px;
--system-dialog-confirm-divider-block-spacing-start: var(
--spectrum-spacing-300
);
--system-dialog-confirm-divider-block-spacing-end: var(
--spectrum-spacing-200
);
--system-dialog-confirm-description-text-color: var(--spectrum-gray-800);
--system-dialog-confirm-title-text-color: var(--spectrum-gray-900);
--system-dialog-confirm-description-text-line-height: var(
--spectrum-line-height-100
);
--system-dialog-confirm-title-text-line-height: var(
--spectrum-line-height-100
);
--system-dialog-heading-font-weight: var(
--spectrum-heading-sans-serif-font-weight
);
--system-dialog-confirm-description-padding: var(--spectrum-spacing-50);
--system-dialog-confirm-description-margin: calc(
var(--spectrum-spacing-50) * -1
);
--system-dialog-confirm-footer-padding-top: var(--spectrum-spacing-600);
--system-dialog-confirm-gap-size: var(
--spectrum-component-pill-edge-to-text-100
);
--system-dialog-confirm-buttongroup-padding-top: var(
--spectrum-spacing-600
);
--system-dialog-confirm-close-button-size: var(
--spectrum-component-height-100
);
--system-dialog-confirm-close-button-padding: calc(
26px - var(--spectrum-component-bottom-to-text-300)
);
--system-dialog-confirm-divider-height: var(--spectrum-spacing-50);
--system-divider-background-color: var(--spectrum-gray-200);
--system-divider-background-color-static-white: var(
--spectrum-transparent-white-200
40 changes: 0 additions & 40 deletions tools/styles/tokens/express/system-theme-bridge.css
View file
Original file line number Diff line number Diff line change
@@ -692,46 +692,6 @@
--spectrum-disabled-background-color
);
--system-combobox-border-color-disabled: transparent;
--system-dialog-fullscreen-header-text-size: 28px;
--system-dialog-min-inline-size: 288px;
--system-dialog-confirm-small-width: 400px;
--system-dialog-confirm-medium-width: 480px;
--system-dialog-confirm-large-width: 640px;
--system-dialog-confirm-divider-block-spacing-start: var(
--spectrum-spacing-300
);
--system-dialog-confirm-divider-block-spacing-end: var(
--spectrum-spacing-200
);
--system-dialog-confirm-description-text-color: var(--spectrum-gray-800);
--system-dialog-confirm-title-text-color: var(--spectrum-gray-900);
--system-dialog-confirm-description-text-line-height: var(
--spectrum-line-height-100
);
--system-dialog-confirm-title-text-line-height: var(
--spectrum-line-height-100
);
--system-dialog-heading-font-weight: var(
--spectrum-heading-sans-serif-font-weight
);
--system-dialog-confirm-description-padding: var(--spectrum-spacing-50);
--system-dialog-confirm-description-margin: calc(
var(--spectrum-spacing-50) * -1
);
--system-dialog-confirm-footer-padding-top: var(--spectrum-spacing-600);
--system-dialog-confirm-gap-size: var(
--spectrum-component-pill-edge-to-text-100
);
--system-dialog-confirm-buttongroup-padding-top: var(
--spectrum-spacing-600
);
--system-dialog-confirm-close-button-size: var(
--spectrum-component-height-100
);
--system-dialog-confirm-close-button-padding: calc(
26px - var(--spectrum-component-bottom-to-text-300)
);
--system-dialog-confirm-divider-height: var(--spectrum-spacing-50);
--system-divider-background-color: var(--spectrum-gray-300);
--system-divider-background-color-static-white: var(
--spectrum-transparent-white-300
40 changes: 0 additions & 40 deletions tools/styles/tokens/spectrum/system-theme-bridge.css
View file
Original file line number Diff line number Diff line change
@@ -698,46 +698,6 @@
--spectrum-disabled-background-color
);
--system-combobox-border-color-disabled: transparent;
--system-dialog-fullscreen-header-text-size: 28px;
--system-dialog-min-inline-size: 288px;
--system-dialog-confirm-small-width: 400px;
--system-dialog-confirm-medium-width: 480px;
--system-dialog-confirm-large-width: 640px;
--system-dialog-confirm-divider-block-spacing-start: var(
--spectrum-spacing-300
);
--system-dialog-confirm-divider-block-spacing-end: var(
--spectrum-spacing-200
);
--system-dialog-confirm-description-text-color: var(--spectrum-gray-800);
--system-dialog-confirm-title-text-color: var(--spectrum-gray-900);
--system-dialog-confirm-description-text-line-height: var(
--spectrum-line-height-100
);
--system-dialog-confirm-title-text-line-height: var(
--spectrum-line-height-100
);
--system-dialog-heading-font-weight: var(
--spectrum-heading-sans-serif-font-weight
);
--system-dialog-confirm-description-padding: var(--spectrum-spacing-50);
--system-dialog-confirm-description-margin: calc(
var(--spectrum-spacing-50) * -1
);
--system-dialog-confirm-footer-padding-top: var(--spectrum-spacing-600);
--system-dialog-confirm-gap-size: var(
--spectrum-component-pill-edge-to-text-100
);
--system-dialog-confirm-buttongroup-padding-top: var(
--spectrum-spacing-600
);
--system-dialog-confirm-close-button-size: var(
--spectrum-component-height-100
);
--system-dialog-confirm-close-button-padding: calc(
26px - var(--spectrum-component-bottom-to-text-300)
);
--system-dialog-confirm-divider-height: var(--spectrum-spacing-50);
--system-divider-background-color: var(--spectrum-gray-300);
--system-divider-background-color-static-white: var(
--spectrum-transparent-white-300
24 changes: 14 additions & 10 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
@@ -7233,23 +7233,27 @@ __metadata:
languageName: node
linkType: hard

"@spectrum-css/dialog@npm:11.0.0-s2-foundations.15":
version: 11.0.0-s2-foundations.15
resolution: "@spectrum-css/dialog@npm:11.0.0-s2-foundations.15"
"@spectrum-css/dialog@npm:12.1.0":
version: 12.1.0
resolution: "@spectrum-css/dialog@npm:12.1.0"
peerDependencies:
"@spectrum-css/closebutton": ">=5"
"@spectrum-css/divider": ">=3"
"@spectrum-css/modal": ">=5"
"@spectrum-css/tokens": ">=14"
"@spectrum-css/underlay": ">=4"
"@spectrum-css/closebutton": ">=6.0.0 <7.0.0"
"@spectrum-css/divider": ">=5.0.0 <6.0.0"
"@spectrum-css/modal": ">=7.0.0 <8.0.0"
"@spectrum-css/tokens": ">=16.0.0 <17.0.0"
"@spectrum-css/underlay": ">=6.0.0 <7.0.0"
peerDependenciesMeta:
"@spectrum-css/closebutton":
optional: true
"@spectrum-css/divider":
optional: true
"@spectrum-css/modal":
optional: true
"@spectrum-css/tokens":
optional: true
"@spectrum-css/underlay":
optional: true
checksum: 10c0/0911458424815f49f08a1c47aa10fb06fbfbdd4ccce9578039730f9f50aae1714997ab0d653ccc58bb6a11f8e776b4ccdb677b22627adb4b43682ac8abe39a91
checksum: 10c0/e6c761eb29e070f5b979dd6925e1b43aa727a24efa0389aa67cad25c1193a6149e1277c6270d0c44c831d6c0c0b2aa1e3c3cec6dde11677567bff756d1090e75
languageName: node
linkType: hard

@@ -8345,7 +8349,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@spectrum-web-components/dialog@workspace:packages/dialog"
dependencies:
"@spectrum-css/dialog": "npm:11.0.0-s2-foundations.15"
"@spectrum-css/dialog": "npm:12.1.0"
"@spectrum-web-components/alert-dialog": "npm:1.5.0"
"@spectrum-web-components/base": "npm:1.5.0"
"@spectrum-web-components/button": "npm:1.5.0"