Skip to content

fix: add type for spreaded FlashObject options #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025

Conversation

charlesfries
Copy link
Contributor

Properties from CustomMessageInfo should be available on FlashObject because they are added to the instance in the constructor. This PR adds a new intersection type called FlashObjectWithOptions that declares this.

for (const [key, value] of Object.entries(messageOptions)) {

image

@charlesfries
Copy link
Contributor Author

@gilest any thoughts on this PR? I think the failed tests are unrelated to my changes, but the logs have expired

@knownasilya
Copy link
Contributor

@charlesfries maybe push up a pr to retrigger a run? Looks like it can't be done from the UI.

This reverts commit d5bfc5a.
@charlesfries
Copy link
Contributor Author

@gilest
Copy link
Contributor

gilest commented Mar 4, 2025

Hi all. Made a PR to restore the CI: #415

@gilest
Copy link
Contributor

gilest commented Mar 4, 2025

Regarding this change - it seems fine.

Regarding this addon - there are unreleased breaking changes on master. Sorry I left it like that, I was trying to batch breaking changes together but the typescript work was never finished.

Take a look at the OP in Release Planning to see where we got to.

Suggestion: release a breaking v6 now or soon. Hopefully someone can own the typescript story after that.

@knownasilya
Copy link
Contributor

Test app changes have been merged, think you can rebase @charlesfries ?

@knownasilya knownasilya merged commit 6f9ff84 into adopted-ember-addons:master Mar 4, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Mar 4, 2025
@charlesfries charlesfries deleted the fix-types branch March 4, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants