Skip to content

Conversation

@Icohedron
Copy link
Contributor

@Icohedron Icohedron commented Apr 9, 2021

This PR builds on top of #170: Run AQA (Comment-Triggered PR Build) workflow

  • Change the Echo parameters step to simply echo the entire JSON of build parameters instead of each individual value in addition to it.

  • Reduce redundant checkouts by using the fact that the current repo is the TKG repo. This also removes the need to modify the TKG checkout action to test changes to runAqaArgParse.py.

  • Implement a new sdk_resource build-jdk which uses the AdoptOpenJDK/build-jdk action to build a JDK using a provided openjdk-build repo.

This functionality was requested in issue adoptium/aqa-tests#2296 but was blocked due to issue adoptium/build-jdk#24 which is still unresolved, but has a (unintended?) workaround that works due to the usePRRef input not causing the action to pull from the PR ref but instead have the action use whatever existing openjdk-build directory is in the workspace (if any).

The same workaround does not work for the eclipse-openj9/build-openj9 action because its similarly-named usePersonalRepo input does checkout the PR ref and also does not accept a custom repo and branch input (eclipse-openj9/build-openj9#18), so the action would need to be rewritten.

Example run: 734853617
image

Implement a new sdk_resource: build-jdk
which uses the AdoptOpenJDK/build-jdk@v1 action to build a JDK using a provided openjdk-build repo.

Signed-off-by: Deric Cheung <[email protected]>
Signed-off-by: Deric Cheung <[email protected]>
@Icohedron Icohedron changed the title Run AQA Workflow: Implement build-jdk sdk_resource Run AQA Workflow: Implement build-jdk sdk_resource, Simplify workflow Apr 10, 2021
@Icohedron Icohedron marked this pull request as ready for review April 10, 2021 01:30
@karianna karianna added the enhancement New feature or request label Apr 16, 2021
@karianna karianna added this to the April 2021 milestone Apr 16, 2021
@Icohedron Icohedron changed the title Run AQA Workflow: Implement build-jdk sdk_resource, Simplify workflow Run AQA Workflow: Implement build-jdk sdk_resource, Remove redundant checkouts Apr 16, 2021
@llxia llxia requested a review from renfeiw April 19, 2021 14:31
@renfeiw renfeiw requested a review from sophia-guo April 19, 2021 15:41
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Contributor

llxia commented May 4, 2021

@renfeiw or @sophia-guo can either of you view this PR? Thanks

@karianna karianna modified the milestones: April 2021, May 2021 May 4, 2021
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 1476a6f into adoptium:master May 4, 2021
@sophia-guo
Copy link
Contributor

Implement a new sdk_resource build-jdk which uses the AdoptOpenJDK/build-jdk action to build a JDK using a provided openjdk-build repo.

The new added sdk_resource enabled to build a JDK using a provided openjdk-build repo. However the JDK isn't setup as TEST_JDK_HOME and used by run-aqa https://github.com/Icohedron/TKG/blob/d39cb9dab495526fd0eeb1ad6c8e9c2b2aaa81e4/.github/workflows/runAqa.yml#L151. The example of run-aqa use a upstream build jdk:

https://github.com/adoptium/run-aqa

    - name: AQA
      uses: AdoptOpenJDK/run-aqa@v1
      env:
         TEST_JDK_HOME: ${{ steps.buildOpenj9.outputs.BuildOpenJ9JDK }}
      with: 
        build_list: 'openjdk'
        target: '_jdk_math'

renfeiw pushed a commit to renfeiw/TKG that referenced this pull request Apr 8, 2022
Run AQA Workflow: Implement build-jdk sdk_resource, Remove redundant checkouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants