Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename classesByName2Test to jdk_classesByName2Test #6091

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

LongyuZhang
Copy link
Contributor

Rerun of this test got skipped since rerun target is based on name.

Issue: ibm_git/runtimes/automation/issues/204

Rerun of this test got skipped since rerun target is based on name.

Signed-off-by: LongyuZhang <[email protected]>
@LongyuZhang
Copy link
Contributor Author

Test Link:

  • hyc-grinder 49010 to generate the failed pipeline, the Rerun failed jdk test cases in Grinder with jdk_custom target will then rerun with jdk_custom.

@LongyuZhang LongyuZhang requested a review from llxia March 22, 2025 00:11
@llxia
Copy link
Contributor

llxia commented Mar 24, 2025

just for the record, OpenJDK test target names are expected to have a certain format to run with the correct custom target (in auto-rerun):

if (failedtest.startsWith("jdk_")) {
if (!jdkFailedTestCaseList.contains(failedTestCasesInfo)) {
jdkFailedTestCaseList += "${failedTestCasesInfo} "
}
} else if (failedtest.startsWith("jck-runtime") || failedtest.startsWith("jckruntime")) {
if (!jckRuntimeFailedTestCaseList.contains(failedTestCasesInfo)) {
jckRuntimeFailedTestCaseList += "${failedTestCasesInfo} "
}
} else if (failedtest.startsWith("jck-compiler") || failedtest.startsWith("jckcompiler")) {
if (!jckCompilerFailedTestCaseList.contains(failedTestCasesInfo)) {
jckCompilerFailedTestCaseList += "${failedTestCasesInfo} "
}
} else if (failedtest.startsWith("jck-devtools") || failedtest.startsWith("jckdevtools")) {
if (!jckDevtoolsFailedTestCaseList.contains(failedTestCasesInfo)) {
jckDevtoolsFailedTestCaseList += "${failedTestCasesInfo} "
}
} else if (failedtest.startsWith("langtools_")){
if (!langtoolsFailedTestCaseList.contains(failedTestCasesInfo)) {
langtoolsFailedTestCaseList += "${failedTestCasesInfo} "
}
} else {
if (!hotspotFailedTestCaseList.contains(failedTestCasesInfo)) {
hotspotFailedTestCaseList += "${failedTestCasesInfo} "

We expect to have a couple more test target name updates as we go through the existing ones.

@LongyuZhang could you update the doc for the expected naming format if we haven't done so? Thanks

@llxia llxia merged commit 952d52f into adoptium:master Mar 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants