Skip to content

Exclude AsyncCloseAndInterrupt.java for JDK11 on z/OS#6093

Merged
LongyuZhang merged 1 commit intoadoptium:masterfrom
psoujany:exclude-nio
Apr 30, 2025
Merged

Exclude AsyncCloseAndInterrupt.java for JDK11 on z/OS#6093
LongyuZhang merged 1 commit intoadoptium:masterfrom
psoujany:exclude-nio

Conversation

@psoujany
Copy link
Contributor

@psoujany psoujany commented Mar 24, 2025

This PR is to exclude java/nio/channels/AsyncCloseAndInterrupt.java due to z/OS limitation for JDK11 on z/OS.

@llxia
Copy link
Contributor

llxia commented Mar 24, 2025

This PR excludes the test on JDK11. However, the title and description are Exclude AsyncCloseAndInterrupt.java for JDK17 on z/OS. I assume we want to exclude on JDK11 (not JDK17).

#java/nio/channels/AsyncCloseAndInterrupt.java is excluded on z/OS due to OS limitation https://github.com/adoptium/aqa-tests/issues/6092 z/OS-s390x
java/nio/channels/AsyncCloseAndInterrupt.java https://github.com/adoptium/aqa-tests/issues/6092 z/OS-s390x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary exclude, we'll be taking this issue with z/OS USS team for the fix. We'll re-enable this test in both JDK11 and JDK17 once the limitation is fixed. Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove line 222

@psoujany psoujany changed the title Exclude AsyncCloseAndInterrupt.java for JDK17 on z/OS Exclude AsyncCloseAndInterrupt.java for JDK11 on z/OS Mar 24, 2025
@llxia
Copy link
Contributor

llxia commented Apr 28, 2025

@psoujany could you please address the above concerns? If this cannot be addressed shortly, please move the PR into draft. Thanks

Signed-off-by: Pasam Soujanya <psoujany@in.ibm.com>
@psoujany
Copy link
Contributor Author

@llxia Updated the PR as suggested. Thank you.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from LongyuZhang April 30, 2025 16:52
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 7760916 into adoptium:master Apr 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants