Add batch player test as part of CI (smoke test) #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a basic batch player test to the CI for Adplay for DOS. It's based on my previous work done for Adplug DOS compatibility
It checks if the executeable actually runs, and no errors are returned. It does not validate the audio output in any way, just that adplay was able to run, play a file in batch mode, and not return any error codes.
Sidenote regarding audio output validation:
I'd really like to be able to crosscheck Adplay for DOS playback with the Adplay for Linux version, to see if there is any regression or other weird issue in the DOS version.
I've ran into issues trying to automate this, since capturing audio from emulated DOS environments can be done, but the emulation causes slight variations in the captured waveforms due to timing differences introduced with the emulation. For example comparing wave/DRO output recordings from multiple DOSBoxX runs show different results each run. I've tried writing a tool to compensate, but have yet to integrate it further. Also doing this takes quite a long time, since all test files will have to be played through a emulator in full, at actual speed.