Refactor end of game functions #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End game actions are refactored to their own methods Added some missing semi-colons to levels.js
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the game file included end-of-game functions that were embedded within the if statement another function. I extracted the function calls within the if statements to their own functions (endGameActions1P and endGameActions2P), to help with code readability.
I also added a couple semi-colons in
levels.jsfor style.The test suite passes after these changes.
closes #99
Please check the high-score logging for 1P games, as there all high score lines are filled after one game (worked like this prior to and after my branch refactoring). @adriennedomingus @erinnachen @rrgayhart
This PR will blow your mind.
