Resolver db 2.0 changes #186
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
femalves
changed the title
tjacovich
requested changes
Apr 24, 2025
adsmp/tests/test_solr_updater.py
Outdated
| @@ -592,7 +592,6 @@ def test_links_data_merge(self): | |||
| self.assertEqual( | |||
| db_record["nonbib_data"]["links_data"], solr_record["links_data"] | |||
| ) | |||
| self.assertEqual(solr_record["has"], []) | |||
There was a problem hiding this comment.
Was this test causing issues?
There was a problem hiding this comment.
No. That was probably something I mistakenly deleted. Thank you for catching that.
| links = self._populate_identifiers(record, resolver_record, links) | ||
|
|
||
| # Set ABSTRACT flag if abstract is present in bib_data | ||
| if 'abstract' in bib_data and bib_data['abstract']: |
There was a problem hiding this comment.
We might need to modify this slightly because I think abstract in this case may refer to the abstract page and not whether or not the record has an abstract. but I need to confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.